Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure files in common/; add a #19514

wants to merge 18 commits into from


Copy link

zcorpan commented Oct 4, 2019

Part of #17913

References to these files have been updated in subsequent commits.

Part of #17913

WIP: references to these files have not yet been updated.
@zcorpan zcorpan mentioned this pull request Oct 4, 2019
11 of 16 tasks complete
@zcorpan zcorpan requested review from gsnedders, jgraham and jugglinmike Oct 4, 2019
@zcorpan zcorpan added the common label Oct 4, 2019
Copy link

jugglinmike commented Oct 4, 2019

I like the new documentation, and I really like the reduction (both the outright deletion of some files and the relocation of others to more specific subdirectories).

Renaming the files introduces risk and involves a good deal more people. That will slow the review process, and rightly so. Renaming seems significantly less valuable to me, so I don't think we should move forward in a way that conflates that with the other improvements.

What do you think about separating the renames into one or (even better) many dedicated pull requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.