Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text directive to text= #19527

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 4, 2019

Change the targetText= directive to text=. Also remove the
non-fragment-directive case and the ## delimiter since we definitely
won't be using them.

Updated all tests to use :~:text= syntax.

Updated web platform tests to reflect text= change and delimiter change
to :~:. Tested updated WPT locally with
run_web_tests.py --additional-driver-flag=
'--enable-blink-features=TextFragmentIdentifiers'

Bug: 1008874,1007016
Change-Id: Ic7f3db39e0a17d5adb8186b2ab5081d60553bd8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835892
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703317}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1835892 branch from 0fbe8bb to 2c9975c Oct 7, 2019
Change the targetText= directive to text=. Also remove the
non-fragment-directive case and the ## delimiter since we definitely
won't be using them.

Updated all tests to use :~:text= syntax.

Updated web platform tests to reflect text= change and delimiter change
to :~:. Tested updated WPT locally with
run_web_tests.py --additional-driver-flag=
  '--enable-blink-features=TextFragmentIdentifiers'

Bug: 1008874,1007016
Change-Id: Ic7f3db39e0a17d5adb8186b2ab5081d60553bd8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835892
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703317}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1835892 branch from 2c9975c to caed935 Oct 7, 2019
@KyleJu KyleJu closed this Oct 9, 2019
@KyleJu KyleJu reopened this Oct 9, 2019
@KyleJu

This comment has been minimized.

Copy link

KyleJu commented Oct 11, 2019

/scroll-to-text-fragment/scroll-to-text-fragment.html appears to be an existing flaky. Please admin merge @foolip

@foolip foolip merged commit 12b4f7d into master Oct 11, 2019
12 of 13 checks passed
12 of 13 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20191009.93 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@foolip foolip deleted the chromium-export-cl-1835892 branch Oct 11, 2019
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Oct 11, 2019

@KyleJu done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.