Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mojo-js: Use correct style for constants #19547

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 7, 2019

Use CONSTANT_CASE for generated constants. Changes all instances that
used the incorrect case.

Bug: 1009251
Change-Id: I79b856996f543650b4cd20e329978936a12adeae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842976
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704073}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

Use CONSTANT_CASE for generated constants. Changes all instances that
used the incorrect case.

Bug: 1009251
Change-Id: I79b856996f543650b4cd20e329978936a12adeae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842976
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704073}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1842976 branch from 68875d0 to 264a18b Oct 9, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f44adb8 into master Oct 9, 2019
11 checks passed
11 checks passed
build-and-publish
Details
Azure Pipelines Build #20191009.16 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1842976 branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.