Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra double quotes in manifest_build.py #19560

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@foolip
Copy link
Contributor

foolip commented Oct 7, 2019

There's no shell escaping at this layer, so these quotes were treated as literal
and included in the release body.

Also add an extra blank line to separate summary and body like in commit messages.

@wpt-pr-bot wpt-pr-bot requested review from gsnedders, jgraham and jugglinmike Oct 7, 2019
@foolip foolip changed the title Remove extra double quotes in release summary/body Remove extra double quotes in manifest_build.py Oct 8, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Oct 8, 2019

Actually I found that this could be simplified by just using %B and not trying to combine summary and summary-less body. If approved I'll squash to a more sensible commit message than is on the branch now.

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Oct 8, 2019

Given #19568 (comment) I'd like to add support from running this in dry run mode on PRs, in case it's totally broken by this.

@jgraham
jgraham approved these changes Oct 8, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Oct 8, 2019

I'll rebase this on top of #19573 when that's landed to get some confidence that it doesn't break everything.

There's no shell escaping at this layer, so these quotes were treated
as literal and included in the release body.

This also simplies the code by using --format=%B.
@foolip foolip force-pushed the foolip/release-quotes branch from 9a9064c to c41721e Oct 9, 2019
@foolip foolip merged commit be08de6 into master Oct 9, 2019
19 checks passed
19 checks passed
build-and-publish
Details
build-and-tag
Details
Azure Pipelines Build #20191009.21 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@foolip foolip deleted the foolip/release-quotes branch Oct 9, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Oct 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.