Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using device serial when using adb. #19583

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 8, 2019

The Android device serial number, specified by the --device-serial
command-line option, was unused by the android_webview wptrunner.
This resulted in adb failing with the following error:

adb wait-for-device
error: more than one device/emulator

Bug: None
Change-Id: I85e236297d7e83950ac26a9283bdad4ef642d62c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845486
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704747}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1845486 branch from cf36dcc to 9f475f0 Oct 9, 2019
The Android device serial number, specified by the --device-serial
command-line option, was unused by the android_webview wptrunner.
This resulted in adb failing with the following error:

    adb wait-for-device
    error: more than one device/emulator

Bug: None
Change-Id: I85e236297d7e83950ac26a9283bdad4ef642d62c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845486
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704747}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1845486 branch from 9f475f0 to 0c27d43 Oct 10, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0e1c5df into master Oct 10, 2019
19 checks passed
19 checks passed
build-and-publish
Details
build-and-tag
Details
Azure Pipelines Build #20191010.139 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1845486 branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.