Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using private properties for data properties of cross-origin properties #19589

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 9, 2019

Since Blink properly supports the incumbent realm now, there is no more need to use OriginSafeMethodSetter, which sets value via V8PrivateProperty.
So there is no need to use V8PrivateProperty also in OriginSafeMethodGetter.

This CL makes it possible to handle "data properties" of cross-origin properties as the proper data properties.

Bug: 715418
Change-Id: I336a8459b80bc63d08a248f3ed7a34dc0806e5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844520
Commit-Queue: Marina Sakai <marinasakai@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706304}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1844520 branch 8 times, most recently from 67d7bb7 to 1bb0ee9 Oct 10, 2019
…perties

Since Blink properly supports the incumbent realm now, there is no more need to use OriginSafeMethodSetter, which sets value via V8PrivateProperty.
So there is no need to use V8PrivateProperty also in OriginSafeMethodGetter.

This CL makes it possible to handle "data properties" of cross-origin properties as the proper data properties.

Bug: 715418
Change-Id: I336a8459b80bc63d08a248f3ed7a34dc0806e5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844520
Commit-Queue: Marina Sakai <marinasakai@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706304}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1844520 branch from 1bb0ee9 to ee21d1c Oct 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ca9c141 into master Oct 16, 2019
11 of 13 checks passed
11 of 13 checks passed
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20191016.16 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1844520 branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.