Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webxr test and sample references to supportsSession #19605

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 9, 2019

Since supportsSession is removed from the spec, convert external webxr
wpt's that rely on that method to internal tests while that method is
deprecated but but still implemented. Update browser tests and sample
pages to use the non-deprecated method as well.

Bug: 1009052
Change-Id: I30249e38828726b31668b609a491792ef17c22ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850361
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704372}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

Since supportsSession is removed from the spec, convert external webxr
wpt's that rely on that method to internal tests while that method is
deprecated but but still implemented.  Update browser tests and sample
pages to use the non-deprecated method as well.

Bug: 1009052
Change-Id: I30249e38828726b31668b609a491792ef17c22ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850361
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704372}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1850361 branch from c01db14 to 11f86b9 Oct 9, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ce015c1 into master Oct 9, 2019
9 checks passed
9 checks passed
Azure Pipelines Build #20191009.156 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1850361 branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.