Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1102175] Part 3 - Add reftests for altering <body> dynamically. #19608

Merged
merged 2 commits into from Oct 12, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Oct 9, 2019

Differential Revision: https://phabricator.services.mozilla.com/D45580

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1102175
gecko-commit: 004a0cb8af9fbbe84522d0506a1fdd132d51944c
gecko-integration-branch: autoland
gecko-reviewers: jfkthame

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

aethanyc added 2 commits Oct 11, 2019
Differential Revision: https://phabricator.services.mozilla.com/D45580

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1102175
gecko-commit: 171c70db54de024df49059cb35bb6be68d5829a7
gecko-integration-branch: autoland
gecko-reviewers: jfkthame
…t from the parent's.

Without this patch, the `CHECK_BLOCK_AND_LINE_DIR` soft assertion in
nsFloatManager can be triggered with
wm-propagation-body-dynamic-change-002.html added in Part 3.

Add the test as a crashtest because web-platform reftest doesn't seem to
catch our soft assertions.

Add reftests to verify that BFC bits are added to the child block if the
parent and child has the same block-direction, but different sideways
bit; also, add reftests to ensure that "text-orientation: sideways"
doesn't add BFC bits.

Differential Revision: https://phabricator.services.mozilla.com/D45912

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1102175
gecko-commit: c42855b477b170876a13ae32a60032d06698814c
gecko-integration-branch: autoland
gecko-reviewers: jfkthame
@moz-wptsync-bot moz-wptsync-bot force-pushed the gecko/1102175 branch from 593c844 to 9372057 Oct 11, 2019
@moz-wptsync-bot moz-wptsync-bot merged commit 0ab72f3 into master Oct 12, 2019
11 checks passed
11 checks passed
Azure Pipelines Build #20191011.155 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1102175 branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.