Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scroll to text feature detectability API #19610

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 9, 2019

Update the feature detectability API to
window.location.fragmentDirective per
WICG/ScrollToTextFragment#19

Also updated web platform tests and confirmed tests pass.

Bug: 1000308
Change-Id: Ib2391abe3d142d57cea61840e721ed35c81089af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850364
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705010}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

Update the feature detectability API to
window.location.fragmentDirective per
WICG/ScrollToTextFragment#19

Also updated web platform tests and confirmed tests pass.

Bug: 1000308
Change-Id: Ib2391abe3d142d57cea61840e721ed35c81089af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850364
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705010}
@KyleJu

This comment has been minimized.

Copy link

KyleJu commented Oct 11, 2019

Flaky on /scroll-to-text-fragment/scroll-to-text-fragment.html but appears to be an existing flaky. Please admin merge @foolip

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Oct 11, 2019

Will do!

@foolip foolip merged commit 084d7fc into master Oct 11, 2019
12 of 13 checks passed
12 of 13 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20191011.41 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@foolip foolip deleted the chromium-export-cl-1850364 branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.