Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland CompressionStream #19614

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 10, 2019

Implement compression for "gzip" and "deflate". The implementation is
hidden behind the ExperimentalCompressionStream flag.

For unit tests, we compress and stream and uncompress it with pako, and
we make sure its output is the same as our original data.

The original CL was reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1849376
due to failures on the MSAN and leak bots.

The compression-stream.any.js test has been modified from the original
version of this CL to improve performance, and also marked as slow.

TBR=kinuko

Bug: 999091
Change-Id: I3952f500cd1ea614397fdf47771e037546583a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851584
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704544}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1851584 branch from 0fa438b to 168c97b Oct 10, 2019
Implement compression for "gzip" and "deflate". The implementation is
hidden behind the ExperimentalCompressionStream flag.

For unit tests, we compress and stream and uncompress it with pako, and
we make sure its output is the same as our original data.

The original CL was reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1849376
due to failures on the MSAN and leak bots.

The compression-stream.any.js test has been modified from the original
version of this CL to improve performance, and also marked as slow.

TBR=kinuko

Bug: 999091
Change-Id: I3952f500cd1ea614397fdf47771e037546583a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851584
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704544}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1851584 branch from 168c97b to 0b45a8d Oct 10, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9f33ed0 into master Oct 10, 2019
13 checks passed
13 checks passed
Azure Pipelines Build #20191010.57 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1851584 branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.