Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the current interval when no more intervals can be resolved #19619

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 10, 2019

When no more intervals can be resolved, ResolveInterval(...) will return
an interval that return false from IsResolved() (meaning it has no
finite begin time). When this happens we should "clear" |interval_| by
setting it to an unresolved interval.

This fixes the behavior of SVGAnimationElement.getStartTime() which now
correctly report (throws) when the last interval of element has ended.
Add a new test for that and move an old somewhat related test to WPT.
Also adjust SVGAnimationTestCase.js which uses this to offset the sample
times (although in most cases) to avoid the debug dump when there's no
current interval (no tests actually rely on the old broken behavior).

This makes us match Firefox.

Bug: 998526
Change-Id: Idcf348343768ffc9392e29af2e976b9a3a1e31aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849897
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#705019}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

When no more intervals can be resolved, ResolveInterval(...) will return
an interval that return false from IsResolved() (meaning it has no
finite begin time). When this happens we should "clear" |interval_| by
setting it to an unresolved interval.

This fixes the behavior of SVGAnimationElement.getStartTime() which now
correctly report (throws) when the last interval of element has ended.
Add a new test for that and move an old somewhat related test to WPT.
Also adjust SVGAnimationTestCase.js which uses this to offset the sample
times (although in most cases) to avoid the debug dump when there's no
current interval (no tests actually rely on the old broken behavior).

This makes us match Firefox.

Bug: 998526
Change-Id: Idcf348343768ffc9392e29af2e976b9a3a1e31aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849897
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#705019}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1849897 branch from 71f7513 to 70cea54 Oct 11, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 052b945 into master Oct 11, 2019
13 checks passed
13 checks passed
Azure Pipelines Build #20191011.47 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1849897 branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.