Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate pregenerated certs #19626

Merged
merged 2 commits into from Oct 14, 2019

Conversation

@gsnedders
Copy link
Contributor

gsnedders commented Oct 10, 2019

We've needed to do this since 2cccd82, but haven't. Whoops.

@wpt-pr-bot wpt-pr-bot requested review from jgraham and jugglinmike Oct 10, 2019
@gsnedders gsnedders force-pushed the gsnedders:update_certs_20191010 branch from e80dcce to 6d9c970 Oct 10, 2019
@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Oct 14, 2019

Failing on macOS:

SecCertificateCreateFromData: Unknown format in import.
Error reading file tools/certs/cacert.pem
@wpt-pr-bot wpt-pr-bot added the ci label Oct 14, 2019
@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Oct 14, 2019

(I on the whole don't think we should land this hack, but… we should see if it works on CI at least)

@wpt-pr-bot wpt-pr-bot added the wptserve label Oct 14, 2019
gsnedders added 2 commits Oct 10, 2019
We've needed to do this since 2cccd82, but haven't. Whoops.

This also stops outputting the text form of the certificate before the
PEM header as macOS/iOS's Security.framework only scans the first 8192
characters for the beginning of the header.
This accidentally got removed in afd4200.
@gsnedders gsnedders force-pushed the gsnedders:update_certs_20191010 branch from 60821e1 to 186d18f Oct 14, 2019
@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Oct 14, 2019

@jgraham can you re-review this?

@jgraham jgraham merged commit b88d541 into web-platform-tests:master Oct 14, 2019
19 checks passed
19 checks passed
build-and-publish
Details
build-and-tag
Details
Azure Pipelines Build #20191014.69 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@gsnedders gsnedders deleted the gsnedders:update_certs_20191010 branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.