Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT REVIEW] Scripts moved between documents #19632

Open

Conversation

@hiroshige-g
Copy link
Contributor

hiroshige-g commented Oct 10, 2019

No description provided.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Oct 11, 2019

@jgraham I discovered via https://github.com/foolip/wpt-stats/commit/f594c4dd3a0962ff26fb7a6c72fdc71d8b265ee9/checks?check_suite_id=260736134 that Taskcluster hasn't started for this PR. Can you report this to the team?

@hiroshige-g I see this is just a draft and it might not matter, but if you want to retrigger you can either close and reopen the PR, or just push new commits.

@wpt-pr-bot wpt-pr-bot added the html label Oct 11, 2019
@foolip foolip removed request for jdm, zcorpan, jgraham, domenic, annevk and zqzhang Oct 18, 2019
@foolip foolip assigned foolip and unassigned annevk Oct 18, 2019
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Oct 18, 2019

See web-platform-tests/wpt-pr-bot#69 for why @wpt-pr-bot assigned people here. I've removed everyone but left myself in the hope that it doesn't add anyone back.

@foolip foolip closed this Oct 18, 2019
@foolip foolip reopened this Oct 18, 2019
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Oct 19, 2019

Weird, still no Taskcluster run here despite closing and reopening. Ping @jgraham.

@domenic

This comment has been minimized.

Copy link
Member

domenic commented Nov 4, 2019

It seems very likely that WIP pull requests do not get CI run, so I'm going to try pushing the "ready to review" button (and maybe closing/reopening) to see what happens.

@domenic domenic marked this pull request as ready for review Nov 4, 2019
@domenic domenic closed this Nov 4, 2019
@domenic domenic reopened this Nov 4, 2019
domenic added 3 commits May 12, 2017
This follows the changes in whatwg/html#2673, but also tests the issue at whatwg/html#2137 in favor of the current spec.
domenic and others added 3 commits Feb 20, 2018
@domenic domenic force-pushed the hiroshige-g:scripts-between-documents-hiroshige branch from faa1022 to 9ad2afe Nov 4, 2019
@foolip foolip removed their assignment Nov 5, 2019
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Nov 5, 2019

@domenic that Taskcluster probably wasn't because this was a draft, but because the branch was based on 0d5ca04 before the Taskcluster config was in the repo. Just rebasing the branch ought to have done the trick, in other words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.