Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Scroll To Text by default #19634

Merged
merged 1 commit into from Jan 20, 2020
Merged

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 11, 2019

Enables scroll to text by default for M81. Note we plan to launch via
Finch for M80.

Intent to ship with LGTMs:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zlLSxQ9BA8Y/t-_3pAiSAwAJ

This patch also updates web platform test expectations:

  • scroll-to-text-fragment.html now passes; it just needed an extra rAF
    for the fallback to element anchor behavior.
  • scroll-to-text-fragment-security.html has two expected failures, as
    they need to be updated to test cross-origin navigations. I'll make
    this change in a follow-up patch to close bug 1042311.

Bug: 919204
Change-Id: Ic2d563934cd9406fb335904a94c390bba789e0b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838701
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732592}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1838701 branch 2 times, most recently from 4664d81 to 66d9595 Jan 15, 2020
Enables scroll to text by default for M81. Note we plan to launch via
Finch for M80.

Intent to ship with LGTMs:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zlLSxQ9BA8Y/t-_3pAiSAwAJ

This patch also updates web platform test expectations:
- scroll-to-text-fragment.html now passes; it just needed an extra rAF
  for the fallback to element anchor behavior.
- scroll-to-text-fragment-security.html has two expected failures, as
  they need to be updated to test cross-origin navigations. I'll make
  this change in a follow-up patch to close bug 1042311.

Bug: 919204
Change-Id: Ic2d563934cd9406fb335904a94c390bba789e0b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838701
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732592}
@stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Jan 20, 2020

Failed Firefox stability check due to having a slow test:

14:46.39 INFO ## Slow tests ##
14:46.39 INFO |                               Test                               | Result | Longest duration (ms) | Timeout (ms) |
14:46.39 INFO |------------------------------------------------------------------|--------|-----------------------|--------------|
14:46.39 INFO | `/scroll-to-text-fragment/scroll-to-text-fragment-security.html` | `OK`   | `10148`               | `10000`      |
14:46.39 INFO 

This change however didn't touch that file, so I suspect it is existing TIMEOUT-flake. cc @nickburris as an FYI, and admin-merging this.

@stephenmcgruer stephenmcgruer merged commit 91ae81e into master Jan 20, 2020
12 of 13 checks passed
12 of 13 checks passed
Community-TC (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20200116.92 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-1838701 branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.