Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new test for content alignment in CSS grid layout #19638

Closed
wants to merge 1 commit into from

Conversation

@ghost
Copy link

ghost commented Oct 11, 2019

Add my first test from webkit

  • Import css-grid-align-content test
  • Import 2 support files needed for this test, not yet in the css-grid/alignment/support folder
@wpt-pr-bot wpt-pr-bot added the css-grid label Oct 11, 2019
@ghost ghost changed the title add grid align content test and 2 support files from webkit add new test for content alignment in CSS grid layout Oct 11, 2019
Copy link
Contributor

javifernandez left a comment

This support file is already in several places, maybe we can avoid adding it again.
I suggest to take a look to other alignment related tests.

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Oct 11, 2019

Closing pull request and opening a new one with personal account (and Igalia's mail).

@ghost ghost closed this Oct 11, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.