Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add util for populating wpt.fyi search index from wpt files #19640

Closed
wants to merge 2 commits into from

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Oct 11, 2019

Luke Bjerring
Copy link
Member

Hexcles left a comment

Code LGTM, but I'm wondering whether this should live in wpt or wpt.fyi.

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Oct 14, 2019

Yeah, it's not exactly clear to me why we're adding a random wpt.fyi-related go file to wpt. Obviously I don't mind if there's a good reason.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Oct 21, 2019

FWIW, I chose to put it inside of WPT because it drastically simplifies the "crawl all the files in WPT" behaviour; however, generally wpt.fyi is a sibling to wpt, so this could easily be replicated into wpt.fyi for code purity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.