Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard current interval if 'end' attribute change renders it invalid #19641

Merged
merged 1 commit into from Oct 12, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 11, 2019

If a mutation of the 'end' attribute ended up introducing an offset
value that was before or at the begin time for the current interval,
we'll no longer have a valid interval (unresolved active duration).
In this case do what ResolveInterval() does and discard the current
interval.

Bug: 1013365
Change-Id: I871c2c235f179dabb31c2347c47f83c53d44b1d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855963
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#705397}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

If a mutation of the 'end' attribute ended up introducing an offset
value that was before or at the begin time for the current interval,
we'll no longer have a valid interval (unresolved active duration).
In this case do what ResolveInterval() does and discard the current
interval.

Bug: 1013365
Change-Id: I871c2c235f179dabb31c2347c47f83c53d44b1d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855963
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#705397}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1855963 branch from f7a4a6b to f288acc Oct 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 52024c8 into master Oct 12, 2019
13 checks passed
13 checks passed
Azure Pipelines Build #20191012.14 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1855963 branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.