Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG/ContentSize: Save unconstrained intrinsic block size in NG for overflow calc. #19642

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 11, 2019

This patch saves the unconstrained intrinsic box size during the
block layout algorithm in order to use it for overflow calculation
in the node. Since we can override the intrinsic size with css-content-size,
we may cause scrollbars to appear. By using unconstrained size, we retain
correct behavior in which scrollbars only depend on the child content,
and not on content-size override.

R=chrishtr@chromium.org, ikilpatrick@chromium.org

Bug: 991096
Change-Id: I0d9cb270ee710b759f93202497f69bf72544f81a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833074
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706135}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1833074 branch 2 times, most recently from f540453 to 4ab98fe Oct 11, 2019
…rflow calc.

This patch saves the unconstrained intrinsic box size during the
block layout algorithm in order to use it for overflow calculation
in the node. Since we can override the intrinsic size with css-content-size,
we may cause scrollbars to appear. By using unconstrained size, we retain
correct behavior in which scrollbars only depend on the child content,
and not on content-size override.

R=chrishtr@chromium.org, ikilpatrick@chromium.org

Bug: 991096
Change-Id: I0d9cb270ee710b759f93202497f69bf72544f81a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833074
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706135}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1833074 branch from 4ab98fe to a02eec7 Oct 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 50fa6ad into master Oct 15, 2019
13 checks passed
13 checks passed
Azure Pipelines Build #20191015.98 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1833074 branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.