Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Correctly infer base rev in pull requests #19650

Conversation

@jugglinmike
Copy link
Contributor

jugglinmike commented Oct 11, 2019

The "before" property is only present in the "Push" GitHub Event. When
building for a pull request, derive the base revision from the "base"
property of the pull request object [2].

[1] https://developer.github.com/v3/activity/events/types/#pushevent
[2] https://developer.github.com/v3/pulls/

The "before" property is only present in the "Push" GitHub Event. When
building for a pull request, derive the base revision from the "base"
property of the pull request object [2].

[1] https://developer.github.com/v3/activity/events/types/#pushevent
[2] https://developer.github.com/v3/pulls/
@foolip
foolip approved these changes Oct 11, 2019
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Oct 11, 2019

We could also just move the rules for what files should trigger the workflow to the yml files, now that GitHub Actions supports that. Any reason to continue doing it ourselves?

@jugglinmike

This comment has been minimized.

Copy link
Contributor Author

jugglinmike commented Oct 11, 2019

Excellent idea. It makes our code simpler and avoids running the GitHub Actions infrastructure only to immediately exit. Let's do that instead: gh-19652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.