Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Correct filtering logic for building docs #19652

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@jugglinmike
Copy link
Contributor

jugglinmike commented Oct 11, 2019

The "before" property is only present in the "Push" GitHub Event [1].
Because of this, the script could not correctly detect changes when
running in response to a "Pull Request" GitHub Event [2].

Remove the file filtering logic from the Bash script and instead rely on
the equivalent functionality as provided by GitHub Actions [3].

[1] https://developer.github.com/v3/activity/events/types/#pushevent
[2] https://developer.github.com/v3/pulls/
[3] https://help.github.com/en/articles/workflow-syntax-for-github-actions#onpushpull_requestpaths

The "before" property is only present in the "Push" GitHub Event [1].
Because of this, the script could not correctly detect changes when
running in response to a "Pull Request" GitHub Event [2].

Remove the file filtering logic from the Bash script and instead rely on
the equivalent functionality as provided by GitHub Actions [3].

[1] https://developer.github.com/v3/activity/events/types/#pushevent
[2] https://developer.github.com/v3/pulls/
[3] https://help.github.com/en/articles/workflow-syntax-for-github-actions#onpushpull_requestpaths
@foolip
foolip approved these changes Oct 11, 2019
@foolip foolip merged commit f162228 into web-platform-tests:master Oct 11, 2019
23 checks passed
23 checks passed
build-and-publish
Details
build-and-tag
Details
Azure Pipelines Build #20191011.162 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@zcorpan zcorpan added GitHub Actions and removed .github labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.