Don't trigger :focus-visible matching if a meta-key was pressed. #19817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 22, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1871715
branch
2 times, most recently
from
5ae8e73
to
718277d
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1871715
branch
2 times, most recently
from
5757d40
to
6262803
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1871715
branch
2 times, most recently
from
3de69b9
to
02adfd8
Compare
Also, move UpdateHadKeyboardEvent() call into KeyboardEventManager::KeyEvent(). Happy to revert the latter change if folks don't like it, but it seemed logically consistent with e.g. gesture detection. Bug: 920458 Change-Id: Ia423a0533325314ae4f83e619337b5a81af0f4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871715 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#709357}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1871715
branch
from
02adfd8
to
78ebf87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, move UpdateHadKeyboardEvent() call into KeyboardEventManager::KeyEvent().
Happy to revert the latter change if folks don't like it, but it seemed logically consistent with e.g. gesture detection.
Bug: 920458
Change-Id: Ia423a0533325314ae4f83e619337b5a81af0f4c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871715
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709357}