Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scroll to text WPT coverage. #20105

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Nov 6, 2019

Adds many tests to the scroll to text WPT suite:

  • Setting window.location.fragmentDirective has no effect
  • All combinations of optional parameters in text directive
  • Matching TextMatchChars and PercentEncodedChars (in particular the
    syntactical characters '&', ‘,’ and ‘-’) including non-ASCII
  • Multiple matches in the page
  • Cross-whitespace/node matching (i.e. context terms and match terms
    can be separated by whitespace and node boundaries)

Also added a readable description to each test case.

Note all tests pass in Chrome except for non-ASCII character matching.

Change-Id: I2a692049ba81bef5412e7b73909fbcdc710eb0da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900648
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713057}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1900648 branch from 2c32f73 to 7604ceb Nov 6, 2019
Adds many tests to the scroll to text WPT suite:
- Setting window.location.fragmentDirective has no effect
- All combinations of optional parameters in text directive
- Matching TextMatchChars and PercentEncodedChars (in particular the
  syntactical characters '&', ‘,’ and ‘-’) including non-ASCII
- Multiple matches in the page
- Cross-whitespace/node matching (i.e. context terms and match terms
  can be separated by whitespace and node boundaries)

Also added a readable description to each test case.

Note all tests pass in Chrome except for non-ASCII character matching.

Change-Id: I2a692049ba81bef5412e7b73909fbcdc710eb0da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900648
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713057}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1900648 branch from 7604ceb to dbebdcd Nov 6, 2019
@Hexcles Hexcles closed this Nov 8, 2019
@Hexcles Hexcles reopened this Nov 8, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 186457c into master Nov 8, 2019
13 of 14 checks passed
13 of 14 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20191108.59 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1900648 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.