Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When performing subtree layout, perform scroll anchoring notifications on ancestors. #20141

Merged
merged 2 commits into from Nov 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Nov 7, 2019

Previously, we would fail to call NotifyBeforeLayout for all such ancestors
that are scrollers, causing subtree layouts to completely fail to maintain
a scroll anchor for such ancestors.

Bug: 920289

Change-Id: I899634949739f5d4f3af1f282b598cbc4ef0e3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902767
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Nick Burris <nburris@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713561}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1902767 branch 2 times, most recently from 902b356 to 5c750fb Nov 7, 2019
…s on ancestors.

Previously, we would fail to call NotifyBeforeLayout for all such ancestors
that are scrollers, causing subtree layouts to completely fail to maintain
a scroll anchor for such ancestors.

Bug: 920289

Change-Id: I899634949739f5d4f3af1f282b598cbc4ef0e3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902767
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Nick Burris <nburris@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713561}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1902767 branch from 5c750fb to 2f13872 Nov 7, 2019
@Hexcles Hexcles closed this Nov 8, 2019
@Hexcles Hexcles reopened this Nov 8, 2019
@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Nov 11, 2019

Looks like a flaky failure in Firefox:

 1:07.29 INFO |                               Test                              | Subtest |          Results           | Messages |
 1:07.29 INFO |-----------------------------------------------------------------|---------|----------------------------|----------|
 1:07.29 INFO | `/css/css-scroll-anchoring/nested-overflow-subtree-layout.html` |         | **FAIL: 2/10, PASS: 8/10** |          |
 1:05.68 TEST_END: FAIL, expected PASS - Testing http://web-platform.test:8000/css/css-scroll-anchoring/nested-overflow-subtree-layout.html == http://web-platform.test:8000/css/css-scroll-anchoring/nested-overflow-subtree-layout-ref.html
Found 7290 pixels different, maximum difference per channel 255

I'm a little surprised not to see the screenshot dumped into the logs (do we not do that for the stability checks?), so I'm going to run this locally on Firefox and see if I can reproduce before pinging the Chromium author.

@stephenmcgruer stephenmcgruer self-assigned this Nov 11, 2019
@jgraham
Copy link
Contributor

jgraham commented Nov 11, 2019

Stability checks eat most of the logs because the log size was occasionally massive (when we were on Travis it would blow through the 50Mb limit). We could make screenshots come through, but some work would be required.

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Nov 11, 2019

Ah, it looks like the class includes reftest-wait.js, but is missing any use of the reftest-wait class. That's probably the problem; I'll add that and see if it passes stability.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit bce5534 into master Nov 11, 2019
10 checks passed
10 checks passed
Azure Pipelines Build #20191111.30 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1902767 branch Nov 11, 2019
@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Nov 11, 2019

That appeared to have worked (stability checks now pass, CL was merged automatically).

FYI @chrishtr - I had to make a slight modification to your patch, see 904b1cf. This should require no action from you; the next WPT import will just import the diff and update Chromium accordingly. Please just take a quick look to make sure my change is sane, thanks.

@chrishtr
Copy link

chrishtr commented Nov 11, 2019

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.