Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use long timeout in webdriver/tests/find_element_from_element/find.py #20153

Conversation

@clopez
Copy link
Contributor

clopez commented Nov 7, 2019

WebKitWebDriver (WebKitGTK) needs at least 55 seconds to run this test.
The default timeout (25+5 seconds) is not enough.
So use a long timeout (180+5) instead for this wdspec test.

…#20153)

* WebKitWebDriver (WebKitGTK) needs at least 55 seconds to run this
test. The default timeout (25+5 seconds) is not enough. So use a long
timeout (180+5) instead for this wdspec test.
@clopez clopez force-pushed the clopez:pr-webkitwebdriver-find.py-timeout branch from 119faea to 46bbd35 Nov 7, 2019
@andreastt andreastt merged commit 2cc5a5c into web-platform-tests:master Nov 8, 2019
11 checks passed
11 checks passed
Azure Pipelines Build #20191107.57 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@carlosgcampos
Copy link
Contributor

carlosgcampos commented Nov 28, 2019

This is because WebKitGTK was too slow, we have fixed that now and the same test is taking ~4 seconds (see fyi). So I think we can revert this now.

carlosgcampos added a commit to WebKitGTK/web-platform-tests that referenced this pull request Nov 28, 2019
andreastt added a commit that referenced this pull request Nov 28, 2019
…rom_element/find.py (#20153) (#20153)" (#20504)

This reverts commit 2cc5a5c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.