Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
[testharness.js] Preserve harness error message #20168
This change does not modify tests because it only effects the harness status string, and we do not validate that.
I checked the "raw" wpt.fyi results for gh-20036. There were 10 occurrences of the generic harness error message in Chrome's data:
Firefox had a significantly greater number:
Following the application of this patch, both browsers report just one test--a legitimate and previously-unreported testing error:
That test was merged after gh-20036, so we shouldn't lose sleep about any lack of care. It was most likely submitted from a branch that didn't include the
Reviewing this patch's effect on results more generally, it doesn't appear to have any unintended side effects:
Although many of the discrepancies are due to pre-existing instabilities, I haven't yet reviewed all of them. I'm opening this pull request now because this problem is blocking gh-19993, so others can verify in my place if they want to move forward before I return tomorrow (EST).