Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text] Fix test and update TestEpectations #20175

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Nov 8, 2019

The test word-break-break-all-inline-006.html is incorrectly defined, as
it was agreed in the corresponding CSS WG issue [1].

This CL changes the expected result of the test and updates the
TestExpectations accordingly, since it was failing for LayoutNG before.

The new expected result matches current LayoutNG's and Gecko's behavior,
but it implies that it fails in legacy and WebKit.

[1] #19903

Change-Id: Ia31c89f1a4084607fbb29fd0422354b754a092d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905549
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714458}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@Hexcles Hexcles closed this Nov 8, 2019
@Hexcles Hexcles reopened this Nov 8, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1905549 branch 3 times, most recently from df04dd1 to 7bbd2f3 Nov 11, 2019
The test word-break-break-all-inline-006.html is incorrectly defined, as
it was agreed in the corresponding CSS WG issue [1].

This CL changes the expected result of the test and updates the
TestExpectations accordingly, since it was failing for LayoutNG before.

The new expected result matches current LayoutNG's and Gecko's behavior,
but it implies that it fails in legacy and WebKit.

[1] #19903

Change-Id: Ia31c89f1a4084607fbb29fd0422354b754a092d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905549
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714458}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1905549 branch from 7bbd2f3 to 3b97287 Nov 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9db5ee0 into master Nov 12, 2019
13 checks passed
13 checks passed
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20191112.33 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1905549 branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.