Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PeerConnection] Update addIceCandidate to use the Operations Chain. #20178

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Nov 8, 2019

Invoke the callback-based version of AddIceCandidate() recently added in
third_party/webrtc.

This CL also...

  • Adds WPT test coverage for two separate but related issues relating to
    the timing between SLD and addIceCandidate which may cause edge-case
    race conditions when exchanging ICE candidates. See referenced bugs.
  • Remove old AddIceCandidate code path.

Bug: chromium:1019222, chromium:1019232
Change-Id: I11d013487325b14739f99617c1d2063a06743524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906368
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714925}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1906368 branch 4 times, most recently from fd81dd6 to fbbea8f Nov 8, 2019
Invoke the callback-based version of AddIceCandidate() recently added in
third_party/webrtc.

This CL also...
- Adds WPT test coverage for two separate but related issues relating to
  the timing between SLD and addIceCandidate which may cause edge-case
  race conditions when exchanging ICE candidates. See referenced bugs.
- Remove old AddIceCandidate code path.

Bug: chromium:1019222, chromium:1019232
Change-Id: I11d013487325b14739f99617c1d2063a06743524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906368
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714925}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1906368 branch from fbbea8f to beb0776 Nov 13, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5675664 into master Nov 13, 2019
13 checks passed
13 checks passed
Azure Pipelines Build #20191113.40 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1906368 branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.