Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent potential timeout results in 2 MathML tests: #20179

Merged
merged 1 commit into from Nov 8, 2019
Merged

Conversation

@fred-wang
Copy link
Contributor

fred-wang commented Nov 8, 2019

cc @rwlbuis

  • css-inline-style-dynamic.tentative.html:
    Verify that MathMLElement.style is defined before using it. Add a
    feature detection for mspace to avoid false positive.

  • href-click-3.html: Handle test_driver's click failure and perform a
    second click with a 'bad' HTML target. If href is supported, the test
    would have completed before the 'bad' handler is called. Otherwise,
    the test will complete in that 'bad' handler.

closes mathml-refresh/mathml#167

- css-inline-style-dynamic.tentative.html:
  Verify that MathMLElement.style is defined before using it. Add a
  feature detection for mspace to avoid false positive.

- href-click-3.html: Handle test_driver's click failure and perform a
  second click with a 'bad' HTML target. If href is supported, the test
  would have completed before the 'bad' handler is called. Otherwise,
  the test will complete in that 'bad' handler.

closes mathml-refresh/mathml#167
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot commented Nov 8, 2019

There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@rwlbuis
rwlbuis approved these changes Nov 8, 2019
Copy link
Contributor

rwlbuis left a comment

LGTM.

@fred-wang fred-wang merged commit 5dde827 into master Nov 8, 2019
10 checks passed
10 checks passed
Azure Pipelines Build #20191108.42 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@fred-wang fred-wang deleted the mathml-timeout branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.