Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null-dereference Read in blink::TransformOperations::ApplyRemaining fix #20183

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Nov 8, 2019

null_ptr get inserted into the Interpolatedtransform as from_ops via Blend function.
This would cause the functions that call the Apply in Interpolatedtransform class to crash.
Added the test case for testing Interpolatedtransform Blend.

Bug: 998938
Change-Id: I34a2e44d0fadf1c0ea848167714adbd0aa656910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887235
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717829}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1887235 branch 4 times, most recently from 2f41294 to d13565c Nov 11, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1887235 branch 6 times, most recently from 3073c17 to 5e240e4 Nov 20, 2019
null_ptr get inserted into the Interpolatedtransform as from_ops via Blend function.
This would cause the functions that call the Apply in Interpolatedtransform class to crash.
Added the test case for testing Interpolatedtransform Blend.

Bug: 998938
Change-Id: I34a2e44d0fadf1c0ea848167714adbd0aa656910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887235
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717829}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1887235 branch from 5e240e4 to c85bce6 Nov 21, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 74dbbd2 into master Nov 21, 2019
7 checks passed
7 checks passed
Azure Pipelines #20191121.93 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1887235 branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.