Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more scroll to text WPTs #20184

Merged
merged 1 commit into from Nov 15, 2019
Merged

Add more scroll to text WPTs #20184

merged 1 commit into from Nov 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Nov 8, 2019

Adds more web platform tests for scroll to text:

  • Combination of non-text directive and text directive
  • Scroll second text directive into view if first doesn't match
  • Matching shadow DOM
  • Don't scroll to hidden text
  • Text that requires a horizontal scroll into view
  • Also fixed non-ASCII test case (and changed to Japanese example)

Change-Id: Id7e21a185897267dc565b19adc7bfdfb5fe70974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903624
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714381}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Adds more web platform tests for scroll to text:

- Combination of non-text directive and text directive
- Scroll second text directive into view if first doesn't match
- Matching shadow DOM
- Don't scroll to hidden text
- Text that requires a horizontal scroll into view
- Also fixed non-ASCII test case (and changed to Japanese example)

Change-Id: Id7e21a185897267dc565b19adc7bfdfb5fe70974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903624
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714381}
@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Nov 12, 2019

One test is flaky-timeout on google-chrome-unstable (9/10 FAIL, 1/10 TIMEOUT). Pinged the CL (https://chromium-review.googlesource.com/c/chromium/src/+/1903624).

@foolip
Copy link
Member

foolip commented Nov 15, 2019

I've filed #20269 and will admin merge this now.

@foolip foolip merged commit fb6ccd5 into master Nov 15, 2019
12 of 13 checks passed
12 of 13 checks passed
Community-TC (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20191112.12 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@foolip foolip deleted the chromium-export-cl-1903624 branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.