Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[websockets] Correct references #20190

Merged
merged 1 commit into from Nov 9, 2019
Merged

Conversation

@jugglinmike
Copy link
Contributor

jugglinmike commented Nov 9, 2019

The test titled 002.html relies on a document which references an
undefined property, asset_equals. Since that value is later invoked as
a function, the test cannot pass. Correct the reference.

The document also incorrectly references the token function instead of
the intended uuid string value. Correct the reference.

The test titled 001.html also includes a misspelled reference, but it
does not rely on the value. Remove the reference.

The test titled `002.html` relies on a document which references an
undefined property, `asset_equals`. Since that value is later invoked as
a function, the test cannot pass. Correct the reference.

The document also incorrectly references the `token` function instead of
the intended `uuid` string value. Correct the reference.

The test titled `001.html` also includes a misspelled reference, but it
does not rely on the value. Remove the reference.
@jdm
jdm approved these changes Nov 9, 2019
@jdm jdm merged commit ff6c692 into web-platform-tests:master Nov 9, 2019
13 checks passed
13 checks passed
Azure Pipelines Build #20191109.9 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.