Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webnfc] Changes for validating external type #21105

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 9, 2020

According to the spec change, this CL

  1. restricts the external type to be an ASCII string.
  2. finds the first occurrence of ':' as the separator between the
    domain name and the type name.

The spec change:
w3c/web-nfc#514
w3c/web-nfc#511

BUG=520391

Change-Id: I7a060bf2d2bc71bc7fca58b59c771d25bac21daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993022
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731103}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1993022 branch 3 times, most recently from 60d934f to 1179d39 Jan 10, 2020
According to the spec change, this CL
  1) restricts the external type to be an ASCII string.
  2) finds the first occurrence of ':' as the separator between the
     domain name and the type name.

The spec change:
w3c/web-nfc#514
w3c/web-nfc#511

BUG=520391

Change-Id: I7a060bf2d2bc71bc7fca58b59c771d25bac21daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993022
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731103}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1993022 branch from 1179d39 to 3d0acc5 Jan 14, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 3c2377f into master Jan 14, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200114.11 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1993022 branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.