Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a test object in wheel event tests #21118

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 9, 2020

When I tried to run mouse event wpt tests manually with mouse wheel,
uievents/order-of-events/mouse-events/wheel-basic-manual.html
uievents/order-of-events/mouse-events/wheel-scrolling-manual.html
I got the error "Harness status: Error done() was called without first
defining any tests". I create a test object inside these two tests and
call done() with these test objects.

Bug: 1040611
Change-Id: I1f11f1587540fb335f4361b2cbbd88c8794a5d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993117
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731538}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

When I tried to run mouse event wpt tests manually with mouse wheel,
uievents/order-of-events/mouse-events/wheel-basic-manual.html
uievents/order-of-events/mouse-events/wheel-scrolling-manual.html
I got the error "Harness status: Error done() was called without first
defining any tests". I create a test object inside these two tests and
call done() with these test objects.

Bug: 1040611
Change-Id: I1f11f1587540fb335f4361b2cbbd88c8794a5d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993117
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731538}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1993117 branch from d605583 to 0c5f764 Jan 14, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 30b4a2b into master Jan 14, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200114.51 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1993117 branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.