Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebCryptoAPI: Fix HKDF test for illegal hash names #21140

Conversation

@tniessen
Copy link
Contributor

tniessen commented Jan 12, 2020

This test is missing the required BufferSource info (see 31.3 of the spec), causing WebIDL conversion to fail instead of the intended error.

Refs: nodejs/webcrypto#36

This test is missing the 'required BufferSource info', causing WebIDL
conversion to fail instead of the intended error.

Refs: nodejs/webcrypto#36
@jimsch
jimsch approved these changes Jan 12, 2020
Copy link
Contributor

jimsch left a comment

Looks fine

@tniessen

This comment has been minimized.

Copy link
Contributor Author

tniessen commented Jan 12, 2020

I don't know why the test failed with a timeout after 2 hours, and why it took that long in the first place.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jan 16, 2020

@tniessen thanks for filing #20052, and sorry that you ran into this.

I've confirmed that wpt-firefox-nightly-stability was the only failing task so I'll admin merge this.

@foolip foolip merged commit bc08822 into web-platform-tests:master Jan 16, 2020
9 of 10 checks passed
9 of 10 checks passed
Community-TC (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20200112.6 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
tniessen added a commit to tniessen/node-webcrypto that referenced this pull request Jan 16, 2020
tniessen added a commit to nodejs/webcrypto that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.