Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1599206] Don't serialize implicit tracks for grid-template properties, as they make the computed style not round-trip. #21147

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jan 13, 2020

Do this only on nightly for now since we're about to enter the soft freeze.

(No test updates yet, as try is still running, and I need to figure out how to
import Oriol's changes into WPT, but I wanted to ensure that you were fine with
this)

Differential Revision: https://phabricator.services.mozilla.com/D54595

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1599206
gecko-commit: 7de69291913b3fafe48f776fa1b6669e54d270a9
gecko-integration-branch: autoland
gecko-reviewers: mats

… make the computed style not round-trip.

Do this only on nightly for now since we're about to enter the soft freeze.

(No test updates yet, as try is still running, and I need to figure out how to
import Oriol's changes into WPT, but I wanted to ensure that you were fine with
this)

Differential Revision: https://phabricator.services.mozilla.com/D54595

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1599206
gecko-commit: 7de69291913b3fafe48f776fa1b6669e54d270a9
gecko-integration-branch: autoland
gecko-reviewers: mats
Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit b122602 into master Jan 14, 2020
11 checks passed
11 checks passed
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20200113.37 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1599206 branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.