Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support features in webxr #21159

Merged

Conversation

@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 14, 2020

Reviewed in servo/servo#25504.

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Servo project.

@Manishearth Manishearth changed the title WIP: support features in webxr Update xrSession_features_deviceSupport to use new user activations for each session request Jan 14, 2020
@Manishearth
Copy link
Contributor

Manishearth commented Jan 14, 2020

@servo-wpt-sync servo-wpt-sync changed the title Update xrSession_features_deviceSupport to use new user activations for each session request WIP: support features in webxr Jan 14, 2020
@servo-wpt-sync servo-wpt-sync changed the title WIP: support features in webxr Support features in webxr Jan 14, 2020
@servo-wpt-sync servo-wpt-sync force-pushed the servo-wpt-sync:servo_export_25504 branch from d9154da to 9d8fd55 Jan 14, 2020
@Manishearth Manishearth changed the title Support features in webxr Update xrSession_features_deviceSupport to use new user activations for each session request Jan 14, 2020
@@ -31,34 +31,27 @@
}

return navigator.xr.test.simulateDeviceConnection(fakeDeviceInitParams)
.then((controller) => new Promise((resolve, reject) => {
navigator.xr.test.simulateUserActivation(() => {
.then((controller) => navigator.xr.test.simulateUserActivation(() =>

This comment has been minimized.

Copy link
@alcooper91

alcooper91 Jan 14, 2020

This last part here shouldn't be needed should it? You can just directly do the new method?

This comment has been minimized.

Copy link
@jdm

This comment has been minimized.

Copy link
@Manishearth

Manishearth Jan 15, 2020

Contributor

Probably yes

This comment has been minimized.

Copy link
@Manishearth

Manishearth Jan 15, 2020

Contributor

Fixed

@servo-wpt-sync servo-wpt-sync changed the title Update xrSession_features_deviceSupport to use new user activations for each session request Support features in webxr Jan 15, 2020
@servo-wpt-sync servo-wpt-sync force-pushed the servo-wpt-sync:servo_export_25504 branch 4 times, most recently from 458770b to 5c4b0c3 Jan 15, 2020
…or each session request
@servo-wpt-sync servo-wpt-sync force-pushed the servo-wpt-sync:servo_export_25504 branch from 5c4b0c3 to 62156e7 Jan 22, 2020
@servo-wpt-sync servo-wpt-sync merged commit 5e8ddbc into web-platform-tests:master Jan 22, 2020
10 checks passed
10 checks passed
Azure Pipelines Build #20200122.16 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@servo-wpt-sync servo-wpt-sync deleted the servo-wpt-sync:servo_export_25504 branch Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.