Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 981248] Rewrite <input type=number> to avoid an anonymous input. #21167

Merged
merged 1 commit into from Jan 16, 2020

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jan 14, 2020

Instead, subclass nsTextControlFrame. This simplifies the code and avoids
correctness issues.

I kept the localization functionality though it is not spec compliant. But I
filed a bug to remove it in a followup.

Differential Revision: https://phabricator.services.mozilla.com/D57193

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=981248
gecko-commit: 1eace7bd28d9986cdd43f5ecb6393a4aa8e9bffc
gecko-integration-branch: autoland
gecko-reviewers: masayuki, surkov, jwatt, ntim, jfkthame, smaug

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

Instead, subclass nsTextControlFrame. This simplifies the code and avoids
correctness issues.

I kept the localization functionality though it is not spec compliant. But I
filed a bug to remove it in a followup.

Differential Revision: https://phabricator.services.mozilla.com/D57193

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=981248
gecko-commit: 010bd182aff8707a95a53310a3e1234bbb8a15dd
gecko-integration-branch: autoland
gecko-reviewers: masayuki, surkov, jwatt, ntim, jfkthame, smaug
@moz-wptsync-bot moz-wptsync-bot force-pushed the gecko/981248 branch from 988308b to 47d0839 Jan 14, 2020
@moz-wptsync-bot moz-wptsync-bot merged commit a12fefb into master Jan 16, 2020
11 checks passed
11 checks passed
Azure Pipelines Build #20200114.56 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/981248 branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.