Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce strict_equality in mypy #21169

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@gsnedders
Copy link
Contributor

gsnedders commented Jan 14, 2020

(this found more bugs on manifest-path-trie)

(this found bugs on manifest-path-trie)
@@ -269,7 +269,7 @@ def filter(self,
target.append(item)

dirnames[:] = keep_dirs
assert ".git" not in dirnames
assert not any(".git" == name for name, _ in dirnames)

This comment has been minimized.

Copy link
@gsnedders

gsnedders Jan 14, 2020

Author Contributor

This assert has been guaranteed to never fail since 4011c5f due to asserting str in List[Tuple[str, T]], which always returns False.

@gsnedders
Copy link
Contributor Author

gsnedders commented Jan 15, 2020

CI failure is #21158

@gsnedders gsnedders merged commit 9c57c8f into web-platform-tests:master Jan 15, 2020
21 of 23 checks passed
21 of 23 checks passed
build-and-publish
Details
build-and-tag
Details
Azure Pipelines Build #20200114.42 failed
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@gsnedders gsnedders deleted the gsnedders:strict_equality branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.