Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1607615] Allow CORS preflights with a default of 5 seconds for expiry if Access-Control-Max-Age hasn't been sent #21170

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jan 14, 2020

The default expiry value is chosen based on what Chromium uses:
https://source.chromium.org/chromium/chromium/src/+/master:services/network/public/cpp/cors/preflight_result.cc;l=27;drc=529117e5ed802c91a5cf192a72b4097d27fcb928?originalUrl=https:%2F%2Fcs.chromium.org%2F

Differential Revision: https://phabricator.services.mozilla.com/D59032

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1607615
gecko-commit: cd769fb3a217024bea3100681e0907e07d1fdd4a
gecko-integration-branch: autoland
gecko-reviewers: mayhemer

…s-Control-Max-Age hasn't been sent

The default expiry value is chosen based on what Chromium uses:
https://source.chromium.org/chromium/chromium/src/+/master:services/network/public/cpp/cors/preflight_result.cc;l=27;drc=529117e5ed802c91a5cf192a72b4097d27fcb928?originalUrl=https:%2F%2Fcs.chromium.org%2F

Differential Revision: https://phabricator.services.mozilla.com/D59032

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1607615
gecko-commit: cd769fb3a217024bea3100681e0907e07d1fdd4a
gecko-integration-branch: autoland
gecko-reviewers: mayhemer
Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit c344b9a into master Jan 14, 2020
11 checks passed
11 checks passed
Azure Pipelines Build #20200114.44 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1607615 branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.