Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementTiming and LargestContentfulPaint: add more redirect tests #21173

Merged
merged 1 commit into from Jan 16, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 14, 2020

This CL adds more tests for Timing-Allow-Origin checks in ElementTiming
and LargestContentfulPaint with multiple redirects. Before, we had tests
for:

  • Single cross-origin response with a TAO header (image-TAO.sub.html).
  • Multiple redirects, with '*' TAO header (multi-redirect-image.html).

This CL renames the latter to be more descriptive and adds:

  • Same-origin redirect tests (should pass without TAO headers).
  • Multi-cross-origin redirect tests with various TAO header values.

Bug: 1003943
Change-Id: Id44f0f18f143c8ca4ee3ca40c2383fa2ae22590c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001070
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732589}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2001070 branch 2 times, most recently from ecab542 to bbc8dbd Jan 16, 2020
This CL adds more tests for Timing-Allow-Origin checks in ElementTiming
and LargestContentfulPaint with multiple redirects. Before, we had tests
for:
* Single cross-origin response with a TAO header (image-TAO.sub.html).
* Multiple redirects, with '*' TAO header (multi-redirect-image.html).

This CL renames the latter to be more descriptive and adds:
* Same-origin redirect tests (should pass without TAO headers).
* Multi-cross-origin redirect tests with various TAO header values.

Bug: 1003943
Change-Id: Id44f0f18f143c8ca4ee3ca40c2383fa2ae22590c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001070
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732589}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2001070 branch from bbc8dbd to cdf56db Jan 16, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 606da53 into master Jan 16, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200116.89 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2001070 branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.