From ee396dfd7fb8ef2d15e373888e0e6f36f89886c9 Mon Sep 17 00:00:00 2001 From: "Hallvord Reiar M. Steen" Date: Mon, 10 Jun 2013 15:27:40 +0200 Subject: [PATCH 1/4] TITLE fix --- XMLHttpRequest/event-readystatechange-loaded.htm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/XMLHttpRequest/event-readystatechange-loaded.htm b/XMLHttpRequest/event-readystatechange-loaded.htm index f2a22bf907e9bc..427428051c81c3 100644 --- a/XMLHttpRequest/event-readystatechange-loaded.htm +++ b/XMLHttpRequest/event-readystatechange-loaded.htm @@ -2,10 +2,10 @@ - XMLHttpRequest: the LOADED state change should only happen once + XMLHttpRequest: the LOADING state change should only happen once - +
From c136f2bd2c8515d2e0a43a43856ed1c74383b6ec Mon Sep 17 00:00:00 2001 From: "Hallvord Reiar M. Steen" Date: Mon, 10 Jun 2013 15:51:45 +0200 Subject: [PATCH 2/4] enhancing LINK references in the new tests --- XMLHttpRequest/abort-after-receive.htm | 2 +- XMLHttpRequest/event-readystatechange-loaded.htm | 4 +++- XMLHttpRequest/response-data-gzip.htm | 2 +- XMLHttpRequest/response-data-progress.htm | 3 ++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/XMLHttpRequest/abort-after-receive.htm b/XMLHttpRequest/abort-after-receive.htm index 44a02ba66af9f6..155431caf19171 100644 --- a/XMLHttpRequest/abort-after-receive.htm +++ b/XMLHttpRequest/abort-after-receive.htm @@ -4,7 +4,7 @@ XMLHttpRequest: abort() after successful receive should not fire "abort" event - +
diff --git a/XMLHttpRequest/event-readystatechange-loaded.htm b/XMLHttpRequest/event-readystatechange-loaded.htm index 427428051c81c3..50f411dea823f5 100644 --- a/XMLHttpRequest/event-readystatechange-loaded.htm +++ b/XMLHttpRequest/event-readystatechange-loaded.htm @@ -5,7 +5,9 @@ XMLHttpRequest: the LOADING state change should only happen once - + + +
diff --git a/XMLHttpRequest/response-data-gzip.htm b/XMLHttpRequest/response-data-gzip.htm index 3e6f04d9f26ef7..2ddbb26b450507 100644 --- a/XMLHttpRequest/response-data-gzip.htm +++ b/XMLHttpRequest/response-data-gzip.htm @@ -4,7 +4,7 @@ XMLHttpRequest: GZIP response was correctly inflated - +
diff --git a/XMLHttpRequest/response-data-progress.htm b/XMLHttpRequest/response-data-progress.htm index a4f890948ab07a..384a1171a8029c 100644 --- a/XMLHttpRequest/response-data-progress.htm +++ b/XMLHttpRequest/response-data-progress.htm @@ -5,7 +5,8 @@ XMLHttpRequest: progress events grow response body size - + + From 7c9c924feb9e2196f9be9386d898b62615af5d39 Mon Sep 17 00:00:00 2001 From: "Hallvord Reiar M. Steen" Date: Mon, 10 Jun 2013 15:58:17 +0200 Subject: [PATCH 3/4] use a timeout for tests that assert an event should not happen, to catch any implementation that might queue the event for later - just in case --- XMLHttpRequest/abort-after-receive.htm | 6 ++++-- XMLHttpRequest/abort-after-timeout.htm | 7 +++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/XMLHttpRequest/abort-after-receive.htm b/XMLHttpRequest/abort-after-receive.htm index 155431caf19171..06d1b9838613ea 100644 --- a/XMLHttpRequest/abort-after-receive.htm +++ b/XMLHttpRequest/abort-after-receive.htm @@ -4,7 +4,7 @@ XMLHttpRequest: abort() after successful receive should not fire "abort" event - +
@@ -22,7 +22,9 @@ assert_equals(client.readyState, 0); - test.done(); + setTimeout(function(){ // use a timeout to catch any implementation that might queue an abort event for later - just in case + test.step(function(){test.done();}); + }, 200); } }); diff --git a/XMLHttpRequest/abort-after-timeout.htm b/XMLHttpRequest/abort-after-timeout.htm index 74c6e85bd9176f..753350c0e20c9c 100644 --- a/XMLHttpRequest/abort-after-timeout.htm +++ b/XMLHttpRequest/abort-after-timeout.htm @@ -4,7 +4,8 @@ XMLHttpRequest: abort() after a timeout should not fire "abort" event - + +
@@ -29,7 +30,9 @@ // abort should not cause the "abort" event to fire - client.abort(); + setTimeout(function(){ // use a timeout to catch any implementation that might queue an abort event for later - just in case + test.step(function(){test.done();}); + }, 200); assert_equals(client.readyState, 0); From 2711b193fe2ffaea1f0e4d9f459b5f12879744ed Mon Sep 17 00:00:00 2001 From: "Hallvord Reiar M. Steen" Date: Tue, 11 Jun 2013 11:20:23 +0200 Subject: [PATCH 4/4] =?UTF-8?q?bugfix:=20removing=20the=20statement=20we'r?= =?UTF-8?q?e=20testing=20was=20not=20intentional.=20Thanks=20=C2=A0@ronkor?= =?UTF-8?q?ving=20for=20catching=20that=20mistake?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- XMLHttpRequest/abort-after-timeout.htm | 1 + 1 file changed, 1 insertion(+) diff --git a/XMLHttpRequest/abort-after-timeout.htm b/XMLHttpRequest/abort-after-timeout.htm index 753350c0e20c9c..b59c51d9192abe 100644 --- a/XMLHttpRequest/abort-after-timeout.htm +++ b/XMLHttpRequest/abort-after-timeout.htm @@ -29,6 +29,7 @@ assert_true(timeoutFired); // abort should not cause the "abort" event to fire + client.abort(); setTimeout(function(){ // use a timeout to catch any implementation that might queue an abort event for later - just in case test.step(function(){test.done();});