Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-scroll-anchoring] Add WPT for zero scroll offset suppression. #21675

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 8, 2020

Chromium has always had a scroll anchoring suppression trigger when the
scroll offset is zero. This suppression trigger was added to the spec in
w3c/csswg-drafts#4679.

Change-Id: I2f38b23803e610aa04976c43211357e173cecbb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045200
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741108}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2045200 branch 2 times, most recently from d965ee1 to 83368dd Feb 10, 2020
Chromium has always had a scroll anchoring suppression trigger when the
scroll offset is zero. This suppression trigger was added to the spec in
w3c/csswg-drafts#4679.

Change-Id: I2f38b23803e610aa04976c43211357e173cecbb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045200
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741108}
@KyleJu
Copy link

KyleJu commented Feb 13, 2020

The following test is flaky on Firefox

/css/css-scroll-anchoring/zero-scroll-offset.html

Subtest Results Messages
OK
Scroll anchoring suppressed when scroll offset is zero. FAIL: 2/5, PASS: 3/5 assert_equals: expected 0 but got 50
@nickburris
Copy link
Contributor

nickburris commented Feb 13, 2020

FYI this is expected to be flaky in firefox (the tested behavior itself is flaky). Let me know if I need to do anything else to merge this!

@KyleJu
Copy link

KyleJu commented Feb 14, 2020

FYI this is expected to be flaky in firefox (the tested behavior itself is flaky). Let me know if I need to do anything else to merge this!

Thanks for looking into it! Could you admin merge this @Hexcles ?

@Hexcles Hexcles merged commit 91d1d5d into master Feb 14, 2020
12 of 13 checks passed
12 of 13 checks passed
Community-TC (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20200213.72 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@Hexcles Hexcles deleted the chromium-export-cl-2045200 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.