Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form-associated custom elements: Fix the initial value of 'submission value' #21747

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 12, 2020

According to https://html.spec.whatwg.org/C/#face-submission-value, the
initial value should be null, not an empty string.

Bug: 1051292
Bug: whatwg/html#5263
Change-Id: Ifa92aaca47bfce1e51aa0fd3dc9ebb9ab9b15d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050148
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741277}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

… value'

According to https://html.spec.whatwg.org/C/#face-submission-value, the
initial value should be null, not an empty string.

Bug: 1051292
Bug: whatwg/html#5263
Change-Id: Ifa92aaca47bfce1e51aa0fd3dc9ebb9ab9b15d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050148
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741277}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2050148 branch from f1cc74c to 3ee8fd8 Feb 14, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 69e5b86 into master Feb 14, 2020
9 checks passed
9 checks passed
Azure Pipelines Build #20200214.5 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2050148 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.