Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make external/wpt/css/cssom-view/elementFromPoint.html robust on browsers #21796

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 14, 2020

This patch changes "elementFromPoint.html" to call |getBoundingClientRect()|
on <img> instead of <area> because all browsers returns different value for
<area>, maybe size-less inline element, for improving robustness of test.

Because test itself verifies |elementFromPoint()| instead of
|getBoundingClientRect()|, this patch doesn't change testing

Change-Id: I40fc2c6c9cef696dc5c9f3428913b2d73ffaf5f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054472
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741374}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

…sers

This patch changes "elementFromPoint.html" to call |getBoundingClientRect()|
on <img> instead of <area> because all browsers returns different value for
<area>, maybe size-less inline element, for improving robustness of test.

Because test itself verifies |elementFromPoint()| instead of
|getBoundingClientRect()|, this patch doesn't change testing

Change-Id: I40fc2c6c9cef696dc5c9f3428913b2d73ffaf5f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054472
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741374}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2054472 branch from 914e30c to 6a96fb7 Feb 14, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9819db1 into master Feb 14, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200214.16 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2054472 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.