Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use errno attribute to handle socket.error for PY2 and PY3 compatibility #21802

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@ziransun
Copy link
Contributor

ziransun commented Feb 14, 2020

Python 3 has introduced Built-in Exception class 'ConnectionRefusedError'
as a subclass of ConnectionError for connection-related issue.

Python 3 has introduced Built-in Exception class 'ConnectionRefusedError'
as a subclass of ConnectionError for connection-related issue.
@jgraham jgraham merged commit f268227 into web-platform-tests:master Feb 14, 2020
29 checks passed
29 checks passed
build-and-publish
Details
build-and-tag
Details
Azure Pipelines Build #20200214.27 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows (Python 3.6)) tools/ unittests: Windows (Python 3.6) succeeded
Details
Azure Pipelines (tools/ unittests: Windows (Python 3.8)) tools/ unittests: Windows (Python 3.8) succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS (Python 3.6)) tools/ unittests: macOS (Python 3.6) succeeded
Details
Azure Pipelines (tools/ unittests: macOS (Python 3.8)) tools/ unittests: macOS (Python 3.8) succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows (Python 3.6)) tools/wpt/ tests: Windows (Python 3.6) succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows (Python 3.8)) tools/wpt/ tests: Windows (Python 3.8) succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS (Python 3.6)) tools/wpt/ tests: macOS (Python 3.6) succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS (Python 3.8)) tools/wpt/ tests: macOS (Python 3.8) succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows (Python 3.6)) tools/wptrunner/ unittests: Windows (Python 3.6) succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows (Python 3.8)) tools/wptrunner/ unittests: Windows (Python 3.8) succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS (Python 3.6)) tools/wptrunner/ unittests: macOS (Python 3.6) succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS (Python 3.8)) tools/wptrunner/ unittests: macOS (Python 3.8) succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - safari[experimental] Safari results
Details
@ziransun ziransun deleted the ziransun:errno branch May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.