Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform tests for ParentNode replaceChildren #21810

Conversation

@snuggs
Copy link
Contributor

snuggs commented Feb 14, 2020

Issue

Implementation

WPT Platform Tests

Bug Trackers

TODO:

  • Better align with #1974 ParentNode / ChildNode imperative test patterns.
  • Flesh out test cases.
  • Remove test double.
@snuggs snuggs self-assigned this Feb 14, 2020
@wpt-pr-bot wpt-pr-bot added the dom label Feb 14, 2020
@wpt-pr-bot wpt-pr-bot requested review from annevk, jdm and zqzhang Feb 14, 2020
@snuggs snuggs changed the title Add tests for ParentNode replaceChildren Add platform tests for ParentNode replaceChildren Feb 14, 2020
@snuggs
Copy link
Contributor Author

snuggs commented Feb 14, 2020

@annevk I hope these specs are leaning closer to the nomenclature / impl. that was recommended last year. Not certain how much coverage we want for this method. I've given a fairly exhaustive list. Seems like tests may overlap with wherever ** replace all ** is used in the dom.

Wanted to throw an example group of assertions up before fleshing out any of the other pending tests. Let me know next steps.
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.