Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 white-space tests with inline starting with a collapsible white space #21965

Merged
merged 2 commits into from Mar 25, 2020

Conversation

@TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Feb 25, 2020

6 tests with inline starting with a collapsible white space

pre-line-051.html
pre-line-052.html
pre-wrap-051.html
pre-wrap-052.html
white-space-pre-051.html
white-space-pre-052.html
reference/ref-filled-green-100px-square.xht

@wpt-pr-bot wpt-pr-bot added the css-text label Feb 25, 2020
@wpt-pr-bot wpt-pr-bot requested review from fantasai, frivoal, kojiishi, nox, plinss and r12a Feb 25, 2020
@TalbotG TalbotG changed the title Trying to add 6 white-space tests 6 white-space tests with inline starting with a collapsible white space Feb 25, 2020
Copy link
Contributor

@frivoal frivoal left a comment

Replaced the duplication of the green square test with reuse of the existing one.

Other than that, these are very nice. Simple tests that none the lest show a bug in Firefox (in the pre and pre-wrap variants). Nice find!

Approved.

@frivoal frivoal merged commit 79847fd into web-platform-tests:master Mar 25, 2020
10 checks passed
10 checks passed
Azure Pipelines Build #20200325.18 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@TalbotG TalbotG deleted the TalbotG:CSS3Text-GT-PR6 branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.