Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: use Wasm to get a SharedArrayBuffer instance #22385

Merged
merged 1 commit into from Mar 24, 2020

Conversation

@annevk
Copy link
Member

@annevk annevk commented Mar 23, 2020

And verify that the SharedArrayBuffer constructor isn't exposed without COOP+COEP.

For #22358.

And verify that the SharedArrayBuffer constructor isn't exposed without COOP+COEP.

For #22358.
// See https://github.com/whatwg/html/issues/5380 for why not `new SharedArrayBuffer()`
assert_equals(globalThis.SharedArrayBuffer, undefined);
assert_false("SharedArrayBuffer" in globalThis);
}, "SharedArrayBuffer constructor does not exist without COOP+COEP");

This comment has been minimized.

@annevk

annevk Mar 24, 2020
Author Member

@syg @domenic any other angles to test?

This comment has been minimized.

@domenic

domenic Mar 24, 2020
Member

Nah that should do it.

@syg
syg approved these changes Mar 24, 2020
Copy link
Contributor

@syg syg left a comment

SAB changes themselves lgtm, with caveat I don't really know how WPTs work.

@annevk annevk merged commit 288c95a into master Mar 24, 2020
11 checks passed
11 checks passed
detect-deployment
Details
Azure Pipelines Build #20200323.6 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@annevk annevk deleted the annevk/sab-to-wasm-switch-remainder branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants