Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT migration] Move align-baseline.html test from css3/flexbox to WPT #22386

Merged
merged 1 commit into from Mar 24, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 23, 2020

align-baseline.html can be migrated to WPT because it doesn't use
Blink internal APIs as well as doesn't have an image baseline. Besides,
the spec exists.

Bug: 1063749
Change-Id: I99706d7929bc572d6fbc4b9ec0d217d7feca920d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114477
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#752688}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2114477 branch 2 times, most recently from 8190dbb to c4dc756 Mar 24, 2020
align-baseline.html can be migrated to WPT because it doesn't use
Blink internal APIs as well as doesn't have an image baseline. Besides,
the spec exists.

Bug: 1063749
Change-Id: I99706d7929bc572d6fbc4b9ec0d217d7feca920d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114477
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#752688}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2114477 branch from c4dc756 to 6975aae Mar 24, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 275e939 into master Mar 24, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200324.6 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2114477 branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants