Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STAT table, fix name IDs, suppress font-synthesis, add fvar instance #22392

Merged
merged 1 commit into from Mar 24, 2020

Conversation

@drott
Copy link
Contributor

@drott drott commented Mar 23, 2020

Concluding from the discussion in #22355 name ids should have values
greater than 255, and the font should have a STAT table. The name id
issue is something the Firefox prints out as an error on the command
line. Add a STAT table, add a named instance for the regular instance,
and move name ids in this change. Also add encoding headers in tests and
references, and suppress font-synthesis as this is needed to help the
test pass on Firefox.

Fixes #22355 for Firefox.

Concluding from the discussion in #22355 name ids should have values
greater than 255, and the font should have a STAT table. The name id
issue is something the Firefox prints out as an error on the command
line. Add a STAT table, add a named instance for the regular instance,
and move name ids in this change. Also add encoding headers in tests and
references, and suppress font-synthesis as this is needed to help the
test pass on Firefox.

Fixes #22355 for Firefox.
@wpt-pr-bot wpt-pr-bot requested review from fantasai, litherum and svgeesus Mar 23, 2020
@drott drott changed the title Add STAT table, fix name IDs Add STAT table, fix name IDs, suppress font-synthesis, add fvar instance Mar 23, 2020
@drott
Copy link
Contributor Author

@drott drott commented Mar 23, 2020

CC @jfkthame - this should be sufficient to make it pass in Firefox, I assume? Thanks for your review.

@jfkthame
Copy link
Contributor

@jfkthame jfkthame commented Mar 23, 2020

Yes, LGTM.

@drott
Copy link
Contributor Author

@drott drott commented Mar 23, 2020

CC @kojiishi - can you LGTM WPT changes, too?

@drott drott merged commit e343467 into web-platform-tests:master Mar 24, 2020
10 checks passed
10 checks passed
Azure Pipelines Build #20200323.27 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@drott
Copy link
Contributor Author

@drott drott commented Mar 24, 2020

Thanks for the quick review, Myles!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants